MSX FUSION-C, Talking about bugs, errors, mistakes | MSX Resource Center (صفحة 14/26)

بواسطة ducasp

Paladin (712)

25-01-2020, 02:03

Updated fusion-c with the latest from the git, it seems that now there is an issue with keyboard routines KeyboardHit and InputChar, the problem seems to be that you have redirected KeyboardHit to Inkey and those are not the same routine at all... Inkey will return the key if there is a key and clear it from the keyboard buffer, while KeyboardHit will simply tell if there is at least a key to be read from keyboard buffer. Result is that this breaks compatibility, where code that before used InputChar after KeyboardHit (as KeyboardHit did not return the key or read the key from keyboard buffer) will no longer work as the key has been cleared by "KeyboardHit"/Inkey.... In my oppinion, if you wanted to get rid of KeyboardHit, it would be better to not redirect it to Inkey as it doesn't have the same behavior, and then would lead the programmer to look for alternatives instead of looking for a bug that is not in the program they have wrote...

بواسطة ericb59

Paragon (1126)

25-01-2020, 12:51

Hi,

Hummm, you are right. redirecting the KeyboardHit function to Inkey was a bad idea.
Do you think I should re-introduce the KeyboardHit ?

بواسطة ducasp

Paladin (712)

25-01-2020, 14:04

I don't see the need for my programs, as Inkey returns immediatelly with 00 if no key has been pressed, so in my programs use scenario of KeyboardHit, it is actually easier to use Inkey.

I would just document that KeyboardHit has been removed and Inkey can be used instead, but that it will grab the key from keyboard buffer if any (unlike KeyboardHit), otherwise return 0, so no one gets confused why the program with KeyboardHit / Inputchar is now needing two key presses (as it has been removed and not redirected to Inkey).

By the way, I've really liked to see Fusion-C evolution in 1.2, you are doing a great job with it, many thanks!

بواسطة ericb59

Paragon (1126)

25-01-2020, 15:55

By the way, I've really liked to see Fusion-C evolution in 1.2, you are doing a great job with it, many thanks!

Thank you very much.
Can you tell me what you liked most about the evolution of FUSION-C ?

I'm working on V1.3.

بواسطة ericb59

Paragon (1126)

26-01-2020, 10:43

Speed comparison between FUSION-C 1.0/1.1 and FUSION-C 1.3

Check the video :
https://youtu.be/qea2uPJaBuA

بواسطة ToriHino

Paladin (926)

26-01-2020, 12:27

Nice! That is quite an improvement in speed

بواسطة raymond

Hero (653)

28-01-2020, 21:30

ericb59 wrote:

Speed comparison between FUSION-C 1.0/1.1 and FUSION-C 1.3

Check the video :
https://youtu.be/qea2uPJaBuA

Nice improvement in speed! Is this difference the same when you compare 1.2 with 1.3?

بواسطة raymond

Hero (653)

28-01-2020, 21:30

ericb59 wrote:

Hi,

Hummm, you are right. redirecting the KeyboardHit function to Inkey was a bad idea.
Do you think I should re-introduce the KeyboardHit ?

As the function is really different, I think it should be re-introduced.

بواسطة ericb59

Paragon (1126)

29-01-2020, 20:12

new optimisation was done on the upcoming v1.3

بواسطة ducasp

Paladin (712)

30-01-2020, 01:01

ericb59 wrote:

By the way, I've really liked to see Fusion-C evolution in 1.2, you are doing a great job with it, many thanks!

Thank you very much.
Can you tell me what you liked most about the evolution of FUSION-C ?

I'm working on V1.3.

Hi Eric,

You certainly spend a good time understanding what we talk to you and fixing it, and not only that but also adding quite a few new features and improving performance on a few functions. That is what I like most: Fusion-C is alive and you do a great job maintaning it. Really glad to see UNAPI library by Eugeny being integrated as well a V9990 library. Best of all, having it on a github also make it easier for future contributions.