MSX FUSION-C, Talking about bugs, errors, mistakes

Found a bug in the Open( char *name, int mode ); function (as part of io.s).

part of the function (just after _iopen:: ) does the following:

	push	hl
	push	de
	push	bc
	call	_OS_version
	call	_prep_fcbs
	pop	bc
	pop	de
	pop	hl

The call to _OS_version modifies (amongst others) the DE register (which after this contains the MSXDOS2.SYS version number, in my case 0x0210 for 2.10). However _prep_fcbs starts with:

_prep_fcbs:
	xor	a
	ld	(de),a

So effectively overwriting adress 0x210 with a zero, meaning it modifies the code at that location. Of course this can lead to all sorts of (undesired) resulting effects. BTW I see the same calls also in the _FCBS:: function.

A first short check shows no real need to put a zero on (DE) so easy solution could be to just remove this, but probably some further check is needed . At least DE in this case contains the second argument (mode), so restoring this before _prep_fcbs makes no sense here.

I did not test it yet but will do. Indeed it makes sense to maybe remove these functions from the library, since there is an overlap with the FCB_ functions anyway as you already state.
Next to that i have my doubts about the functionality of the fseek functions in io as well. They don't seem to work as intended but also did go further into that as well.

I recently switched to SDCC 4.0. Works fine, only get one warning:

?ASlink-Warning-Definition of public symbol '_printf' found more than once:
   Library: '../fusion-c/lib/fusion.lib', Module: 'printf.rel'
   Library: 'C:\Program Files\SDCC\bin\..\lib\z80/z80.lib', Module: 'vprintf.rel'

?ASlink-Warning-Definition of public symbol '_printf' found more than once:
   Library: '../fusion-c/lib/fusion.lib', Module: 'printf.rel'
   Library: 'C:\Program Files\SDCC\bin\..\lib\z80/z80.lib', Module: 'vprintf.rel'

Have you re-done the sdar steps?

> cp z80.lib z80.save
> sdar -d z80.lib printf.rel
> sdar -d z80.lib sprintf.rel
> sdar -d z80.lib vprintf.rel
> sdar -d z80.lib putchar.rel
> sdar -d z80.lib getchar.rel

I have no such issue.

3.6 as advised in the manual

I see a lot of coders are using 4.0, perhaps I will switch as well then