VGMPlay for MSX

Page 26/43
19 | 20 | 21 | 22 | 23 | 24 | 25 | | 27 | 28 | 29 | 30 | 31

By Parn

Champion (352)

Parn's picture

16-11-2017, 14:38

Very nice, Grauw. Thank you! Wink

By Grauw

Enlighted (8015)

Grauw's picture

16-11-2017, 22:05

A little aside, Chris Covell released a PC-Engine SCC music disk with several Konami SCC songs converted to the PC-Engine’s sound chip (which is quite similar). Some nice technical details here!

Note to self, I really should try to play PC-Engine on 2xSCC + 2xPSG with VGMPlay… :) Though the frequency modulation on the 1st channel could be a bit of a problem, maybe I could try to use the SCC’s channel rotation function in the test register? I’m not sure if that affects the sound output or only the data read, would need to try.

By Pencioner

Paladin (893)

Pencioner's picture

16-11-2017, 23:19

Nice, thank you for bringing the other chips music to MSX - sounds really great Smile

I tried to make it print dots:
patch is here: neonlib diff

Though i understand that it is not really convenient to change the whole lib proc System_PrintDecDEHL to print dots all the time, but i didn't think about better solution, maybe 'clone' the proc under System_PrintDecDEHL_dots name? It is not too good as well because of not following DRY principle, but other possibility to pass zero/non-zero in register A to indicate dots/no-dots is no good either as other users of library will be affected by this change... so i'm kinda stuck here :)

By Grauw

Enlighted (8015)

Grauw's picture

16-11-2017, 23:30

Also if the number is < 1 million or < 1000 it should not print the commas.

But thanks! I’ll put it in the coming release some way or another!

By Pencioner

Paladin (893)

Pencioner's picture

16-11-2017, 23:33

that's why it does
call nz, PrintDot
not just
call PrintDot
because i've read the code and if the previous digit was not printed (it's a leading zero) then it returns from Digit and DigitReverse having Z flag set - my change will print all numbers correctly

By Grauw

Enlighted (8015)

Grauw's picture

16-11-2017, 23:35

Great… already taken care of! Smile

By Grauw

Enlighted (8015)

Grauw's picture

17-11-2017, 00:06

Hm actually, I think it looks a bit messy, at least in 40 columns mode. Also with space separators. Maybe instead I should align the numbers to the right. Or show the frequency as MHz. Or the amount of detune. Eventually though (not short term) I want to correct note frequencies and then it should no longer have value to show it at all.

By Pencioner

Paladin (893)

Pencioner's picture

17-11-2017, 00:04

Yep, actually i did it for fun, so no worries, and when you say to print MHz it is already not that trivial (32 bit division that is...) so let it print in Hz as before. I already learnt that there's more decimal signs than i was seeing at first glance Tongue And when you correct freqs it will be the best release hehe Smile

By Manuel

Ascended (15361)

Manuel's picture

17-11-2017, 08:39

So, does it print commas or dots depending on the region code? ;-)

By Pencioner

Paladin (893)

Pencioner's picture

17-11-2017, 09:31

Nope, i'm lame asm coder, you select char to print before you compile the player Wink

Page 26/43
19 | 20 | 21 | 22 | 23 | 24 | 25 | | 27 | 28 | 29 | 30 | 31